Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: sqlalchemy warning #21

Open
wants to merge 1 commit into
base: second-edition-top
Choose a base branch
from
Open

fix: sqlalchemy warning #21

wants to merge 1 commit into from

Conversation

dextto
Copy link

@dextto dextto commented Jul 8, 2023

Integration test results has an warning message according to SQLAlchemy on the tag ed2-c06-s04.
This is because of using deprecated module.

============================================================ warnings summary ============================================================
rentomatic/repository/postgres_objects.py:4
  /Users/dexter/src/rentomatic/rentomatic/repository/postgres_objects.py:4: MovedIn20Warning: The ``declarative_base()`` function is now available as sqlalchemy.orm.declarative_base(). (deprecated since: 2.0) (Background on SQLAlchemy 2.0 at: https://sqlalche.me/e/b8d9)
    Base = declarative_base()

@lgiordani
Copy link
Contributor

lgiordani commented Jul 10, 2023 •
edited
Loading

Thanks! I will fix this as soon as possible. The process is a bit cumbersome, as I have to commit, rebase and tag again to keep the book in sync with the repository, so I can't just merge this PR. I will keep it open until I'm done with the process. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dextto @lgiordani